Skip to content

der: bound Decode(Value)::Error on core::error::Error #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Dec 26, 2025
Merged

der: bound Decode(Value)::Error on core::error::Error #2137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions der/src/decode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ use crate::EncodingRules;
)]
pub trait Decode<'a>: Sized + 'a {
/// Type returned in the event of a decoding error.
type Error: From<Error> + 'static;
type Error: core::error::Error + From<Error> + 'static;

/// Attempt to decode this TLV message using the provided decoder.
fn decode<R: Reader<'a>>(decoder: &mut R) -> Result<Self, Self::Error>;
Expand Down Expand Up @@ -193,7 +193,7 @@ impl<T: DecodeOwned<Error = Error> + PemLabel> DecodePem for T {
/// ```
pub trait DecodeValue<'a>: Sized {
/// Type returned in the event of a decoding error.
type Error: From<Error> + 'static;
type Error: core::error::Error + From<Error> + 'static;

/// Attempt to decode this value using the provided [`Reader`].
fn decode_value<R: Reader<'a>>(reader: &mut R, header: Header) -> Result<Self, Self::Error>;
Expand All @@ -217,7 +217,7 @@ where
T: ToOwned + ?Sized,
&'a T: DecodeValue<'a, Error = E>,
T::Owned: for<'b> DecodeValue<'b, Error = E>,
E: From<Error> + 'static,
E: core::error::Error + From<Error> + 'static,
{
type Error = E;

Expand Down
10 changes: 9 additions & 1 deletion der/tests/derive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,21 @@
#[allow(dead_code)]
pub struct CustomError(der::Error);

impl core::error::Error for CustomError {}

impl core::fmt::Display for CustomError {
fn fmt(&self, _: &mut core::fmt::Formatter) -> core::fmt::Result {
unimplemented!()
}
}

impl From<der::Error> for CustomError {
fn from(value: der::Error) -> Self {
Self(value)
}
}

impl From<std::convert::Infallible> for CustomError {
impl From<core::convert::Infallible> for CustomError {
fn from(_value: std::convert::Infallible) -> Self {
unreachable!()
}
Expand Down