word: cleanup helper functions #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the internal helper functions in the `word` module, adding a `choice_from_*` prefix to functions that return a `Choice`, and getting rid of `*word*` in the function name since it's implicit from the `word::*` prefix which is used ubiquitously when calling these functions. Also changes the argument order of `select` and `select_wide` (as newly renamed) so the `Choice` is the last argument, which is more consistent with the rest of the codebase.
tarcieri
force-pushed
the
word/cleanup-helper-functions
branch
from
06dc7ff to
c361333
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1044 +/- ##
=======================================
Coverage 79.28% 79.29%
=======================================
Files 164 164
Lines 17497 17496 -1
=======================================
Hits 13873 13873
+ Misses 3624 3623 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the internal helper functions in the
wordmodule, adding achoice_from_*prefix to functions that return aChoice, and getting rid of*word*in the function name since it's implicit from theword::*prefix which is used ubiquitously when calling these functions.Also changes the argument order of
selectandselect_wide(as newly renamed) so theChoiceis the last argument, which is more consistent with the rest of the codebase.