Replace ConstantTimeSelect with ctutils::CtSelect
#1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ConstantTimeSelect` trait was a workaround for having a trait-based API that works for `Boxed*` and non-boxed types, since we can't impl `subtle::ConditionallySelectable` on `Boxed*` types since it has a `Copy` bound. `ctutils::CtSelect` accomplishes the same goals by having only a `Sized` bound (since we need to be able to return selected values). This commit completely replaces the `ConstantTimeSelect` trait with `ctutils::CtSelect`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
+ Coverage 79.21% 79.29% +0.08%
==========================================
Files 164 164
Lines 17514 17497 -17
==========================================
+ Hits 13873 13874 +1
+ Misses 3641 3623 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
As far as boxed ops go, since that's mainly what this PR impacts, I'm actually seeing a bunch of performance improvements for the most part, but all within a range where they may be spurious. So far there's only one 13% regression (in |
tarcieri
deleted the
replace-constanttimeselect-with-ctutils-ctselect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConstantTimeSelecttrait was a workaround for having a trait-based API that works forBoxed*and non-boxed types, since we can't implsubtle::ConditionallySelectableonBoxed*types since it has aCopybound.ctutils::CtSelectaccomplishes the same goals by having only aSizedbound (since we need to be able to return selected values).This commit completely replaces the
ConstantTimeSelecttrait withctutils::CtSelect.