word: delegate some ops to ctutils::Choice
#1042
Merged
+61
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
delegate-some-word-ops-to-ctutils
branch
from
cd5bdf2 to
776dc69
Compare
Conditionally calls certain `u32`/`u64`/`u128` bit twiddling operations defined on `ctutils::Choice` based on `target_pointer_width`, rather than duplicating non-trivial implementations in `ctutils`. This also goes ahead and bumps to the `ctutils` v0.1.2 crate release to pick up the relevant functions.
tarcieri
force-pushed
the
delegate-some-word-ops-to-ctutils
branch
from
776dc69 to
0428925
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
=======================================
Coverage 79.21% 79.21%
=======================================
Files 164 164
Lines 17520 17514 -6
=======================================
- Hits 13878 13874 -4
+ Misses 3642 3640 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally calls certain
u32/u64/u128bit twiddling operations defined onctutils::Choicebased ontarget_pointer_width, rather than duplicating non-trivial implementations inctutils.This also goes ahead and bumps to the
ctutilsv0.1.2 crate release to pick up the relevant functions.