rename Output to AvailableOutput + try_from device_id#867
Open
rename Output to AvailableOutput + try_from device_id#867
Conversation
yara-blue
force-pushed
the
try_from-device_id
branch
from
b341fd7 to
ed53c37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got some feedback on the new experimental Speakers (the next sink) API that was already merged into Rodio under the experimental flag: RustAudio/rodio-experiments#1 (comment)
In short, we need a way to serialize/de-serialize devices (abstracted as
AvailableOutput). I played around a bit with yet another wrapper but since DeviceId is stable and Rodio is married happily to CPAL that ended up not making too much sense. We can always revisit that later (it would be nice for end users not to need to know anything about CPAL to use Rodio.For now you can get a DeviceId from an AvailableOutput and try_from an DeviceId into a AvailableOutput.