fix: remove rust-toolchain.toml to avoid forcing toolchain on all developers #819
Conversation
…elopers PR #814 added rust-toolchain.toml for Nix flake support, but this file affects all developers using rustup, not just Nix users. The pinned version (1.91) is outdated and conflicts with CI which tests against stable/beta/nightly. This change: - Removes rust-toolchain.toml - Updates flake.nix to specify stable Rust directly using rust-overlay - Keeps Nix-specific config in Nix files without affecting other devs
Should we not test CI against a single known version? Right now every PR tends to have to fix the latest new clippy issues. On the other hand it does spread the load of dealing with new clippy lints 😆 Let me know what you think (I've no serious objection against CI running against the world) |
| system: let | ||
| pkgs = inputs.nixpkgs.legacyPackages.${system}.extend inputs.rust-overlay.overlays.default; | ||
| rust = pkgs.rust-bin.fromRustupToolchainFile ./rust-toolchain.toml; | ||
| rust = pkgs.rust-bin.stable.latest.default.override { |
There was a problem hiding this comment.
should be a specific version and not just latest stable, otherwise the project is not reproducible.
There was a problem hiding this comment.
let me know if you dont use nix yourselves though
There was a problem hiding this comment.
To tell you the truth I don't even know what it is, I just threw this together.
|
Sure, then we'd have to find the MSRV, set it in Cargo.toml and set the CI accordingly. cpal just went to 1.78. I don't mind running floppy on stable at the same time: I kinda like continuously fixing the new and improved lints. |
|
@yara-blue what do you want to do here? I don't use nix and don't really like the toolchain being forced this way. |
|
Can we keep it and set it to the MSRV? There should be a tool to find the minimum in an automated fashion. Offtopic; I'm sick and might be for a little while so my responses will be somewhat erratic sorry. |
I am for setting an MSRV, I can work that out. I don't like forcing the toolchain to the MSRV though. My workflow is developing with Rust stable - better lints and compiler messages - and then ensuring it works on MSRV too. I think that's pretty typical.
Health first. Beterschap! |
PR #814 added
rust-toolchain.tomlfor Nix flake support, but this file affects all developers using rustup, not just Nix users. The pinned version (1.91) is outdated and conflicts with CI which tests against stable/beta/nightly.This change:
rust-toolchain.tomlflake.nixto specify stable Rust directly usingrust-overlay