-
Notifications
You must be signed in to change notification settings - Fork 490
ASIO: open control panel #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sin-tel
wants to merge
6
commits into
RustAudio:master
Choose a base branch
from
Sin-tel:asio_control_panel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ASIO: open control panel #1074
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
73f4294
ASIO: Extension trait + open control panel
Sin-tel 3fd65a7
Merge branch 'master' into asio_control_panel
Sin-tel 3c20149
fix driver loading in device
Sin-tel a9f89aa
review fixes
Sin-tel 7542fac
Merge remote-tracking branch 'upstream/master' into asio_control_panel
Sin-tel 8307def
new API
Sin-tel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| //! Implementations for ASIO-specific device functionality. | ||
|
|
||
| #[allow(unused_imports)] | ||
| use crate::BackendSpecificError; | ||
| use crate::Device; | ||
|
|
||
| /// Extension trait to get ASIO device. | ||
| pub trait AsioDeviceExt { | ||
Sin-tel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| fn as_asio(&self) -> Option<AsioDevice<'_>>; | ||
| } | ||
|
|
||
| /// Struct containing for ASIO-specific device functionality. | ||
| #[cfg(all(target_os = "windows", feature = "asio"))] | ||
| pub struct AsioDevice<'a>(&'a crate::host::asio::Device); | ||
|
|
||
| #[cfg(not(all(target_os = "windows", feature = "asio")))] | ||
| pub struct AsioDevice<'a>(std::marker::PhantomData<&'a ()>); | ||
|
|
||
| #[cfg(all(target_os = "windows", feature = "asio"))] | ||
| impl AsioDevice<'_> { | ||
| /// Opens the ASIO driver's control panel window. | ||
| /// | ||
| /// This provides access to device-specific settings like buffer size, | ||
| /// sample rate, input/output routing, and hardware-specific features. | ||
| /// | ||
| /// # Blocking Behavior | ||
| /// | ||
| /// **WARNING**: This call may block until the user closes the control panel. | ||
| /// Consider spawning a thread to avoid blocking the main thread. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns an error if this device is not an ASIO device. | ||
| pub fn open_control_panel(&self) -> Result<(), BackendSpecificError> { | ||
| use crate::host::asio::GLOBAL_ASIO; | ||
|
|
||
| let description = self.0.description().map_err(|e| BackendSpecificError { | ||
| description: format!("{e:?}"), | ||
| })?; | ||
| let driver_name = description.name(); | ||
|
|
||
| GLOBAL_ASIO | ||
| .get() | ||
| .expect("GLOBAL_ASIO is always set when an ASIO Device exists") | ||
| .load_driver(driver_name) | ||
| .map_err(|e| BackendSpecificError { | ||
| description: format!("{e:?}"), | ||
| })? | ||
| .open_control_panel() | ||
| .map_err(|e| BackendSpecificError { | ||
| description: format!("{e:?}"), | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| impl AsioDeviceExt for Device { | ||
| fn as_asio(&self) -> Option<AsioDevice<'_>> { | ||
| match self.as_inner() { | ||
| #[cfg(all(target_os = "windows", feature = "asio"))] | ||
| crate::platform::DeviceInner::Asio(d) => Some(AsioDevice(d)), | ||
| _ => None, | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.