Update activecode locked and highlighted region markings on scroll#1190
Open
ascholerChemeketa wants to merge 1 commit intoRunestoneInteractive:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and rendering of locked and highlighted lines in the
ActiveCodeinteractive editor, especially when scrolling or when only part of the code is visible. The main focus is to ensure that decorations for locked and highlighted lines are applied correctly to only the visible lines, enhancing performance and visual consistency.Editor rendering and decoration improvements:
setHighlightLinesto only highlight lines that are currently visible in the editor, using theviewFromandviewToproperties for accurate line offsets.Locked line marker placement and decoration:
placeLockfunction, and updated its usage to place markers at the correct line numbers.