Skip to content

issuee-1143 Ensure minimum activities in ActivitiesRequiredCell component #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
morozov-av wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

issuee-1143 Ensure minimum activities in ActivitiesRequiredCell component #1144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...ponents/routes/AssignmentBuilder/components/reading/components/ActivitiesRequiredCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,20 @@ interface ActivitiesRequiredCellProps {
itemId: number;
}

const MIN_ACTIVITIES = 1;

export const ActivitiesRequiredCell = ({
value,
exercise,
onUpdate,
itemId
}: ActivitiesRequiredCellProps) => {
const { showToast } = useToastContext();
const [currentValue, setCurrentValue] = useState(value || 0);
const [currentValue, setCurrentValue] = useState(value || MIN_ACTIVITIES);

const handleValueChange = (newValue: number | null | undefined) => {
const numValue = newValue ?? 0;
const activityCount = exercise.numQuestions || 0;
const numValue = newValue ?? MIN_ACTIVITIES;
const activityCount = exercise.numQuestions || MIN_ACTIVITIES;

if (numValue > activityCount) {
showToast({
Expand All @@ -31,7 +33,7 @@ export const ActivitiesRequiredCell = ({
detail: `# required (${numValue}) must not exceed the activity count (${activityCount}).`
});

setCurrentValue(value || 0);
setCurrentValue(value || MIN_ACTIVITIES);
return;
}

Expand All @@ -43,8 +45,8 @@ export const ActivitiesRequiredCell = ({
<InputNumber
value={currentValue}
onValueChange={(e) => handleValueChange(e.value)}
min={0}
max={exercise.numQuestions || 0}
min={MIN_ACTIVITIES}
max={exercise.numQuestions || MIN_ACTIVITIES}
showButtons={false}
style={{
width: "100%",
Expand Down