Skip to content

Update activecode keybindings #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ascholerChemeketa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update activecode keybindings #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 34 additions & 17 deletions bases/rsptx/interactives/runestone/activecode/js/activecode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,29 +377,46 @@ export class ActiveCode extends RunestoneBase {
}
// capture current this for use in event handler
let acElement = this;
$(window).keydown(function (e) {
//Solving Keyboard Trap of ActiveCode: If user use tab for navigation outside of ActiveCode, then change tab behavior in ActiveCode to enable tab user to tab out of the textarea
var code = e.keyCode ? e.keyCode : e.which;
if (code == 9 && $("textarea:focus").length === 0) {

// document level event handler for tab key to handle context switching
// detect if tab key was used to get into the editor
document.addEventListener("keydown", function (e) {
if (e.key === "Tab") {
editor.tabDown = true;
}
});
document.addEventListener("keyup", function (e) {
if (e.key === "Tab") {
editor.tabDown = false;
}
});
editor.getInputField().addEventListener("focus", function (e) {
// Solving Keyboard Trap of ActiveCode: If user uses Tab to navigate to the
// activecode, let Tab get them out
if (editor.tabDown) {
editor.setOption("extraKeys", {
Tab: function (cm) {
$(document.activeElement)
.closest(".tab-content")
.nextSibling.focus();
},
"Shift-Tab": function (cm) {
$(document.activeElement)
.closest(".tab-content")
.previousSibling.focus();
},
Tab: false,
"Shift-Tab": false,
});
} else {
editor.setOption("extraKeys", {
Tab: "indentMore",
"Shift-Tab": "indentLess",
});
}
if ((e.originalEvent.code == "KeyS") && e.originalEvent.ctrlKey) {
});
// keyboard shortcuts for run (ctrl/cmd + s) and comment (ctrl/cmd + /)
this.containerDiv.addEventListener("keydown", function (e) {
if (e.code === "KeyS" && (e.ctrlKey || e.metaKey)) {
if (acElement.runButton.disabled)
return;
acElement.runButton.click();
e.preventDefault();
}
if ((e.originalEvent.code == "Slash") && e.originalEvent.ctrlKey) {
editor.toggleComment();
if (e.code === "Slash" && (e.ctrlKey || e.metaKey)) {
if (typeof editor.toggleComment === "function") {
editor.toggleComment();
}
e.preventDefault();
}
});
Expand Down