Great improvement. couple of questions #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeadeleke
commented
Dec 11, 2013
mikeadeleke
commented
- Is my code good up to Eagle level?
- I'm trying to figure our what to stub and how to show a "hit" or "miss"
Member
There was a problem hiding this comment.
you have a method request and an attr_reader request. why? and do you understand why you can't do that?
Author
There was a problem hiding this comment.
Oh that is a mistake. I made the "request" method to assign the value true. Although, I do not really know why doing both is not a good idea
Member
There was a problem hiding this comment.
Here's a reason why that's no good. The def temp overrides the attr_accessor http://rubyfiddle.com/riddles/f1f85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.