Week 1 complete #19
Open
Week 1 complete #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackjack.rb
Outdated
Member
There was a problem hiding this comment.
I wonder if you want to be testing the hit method, or another method that tests the cards to see if a bust condition was reached. That method would be easier tested, because you could pass it the cards to tell if it it busted or not.
Then, you could test that the hit returns (or at least calls) the bust_condition_test
Member
|
looks good --- I added some notes on the hit method... I might not be making sense on that... see if you follow --- if not, let me know! |
…test condition & if method is received by #hit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed all assignments, however I was unable to write one test (to check if the player goes bust). Please see the comment I left in the commit.