Merged
Conversation
yukideluxe
reviewed
Jan 24, 2026
Member
yukideluxe
left a comment
yukideluxe
left a comment
There was a problem hiding this comment.
Thanks for trying to make this complicate code better! I have some thoughts 🙆🏻♀️
…urrency_delimiters
yukideluxe
approved these changes
Feb 4, 2026
Member
yukideluxe
left a comment
yukideluxe
left a comment
There was a problem hiding this comment.
THANK YOU!!!!!!! Those tests are amazing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactor the delimiter detection logic to improve overall readability and structure. I moved the
enforce_currency_delimiterscheck to the beginning of the process to ensure that when the option is enabled, the currency's delimiters are respected immediately before any automatic detection logic is attempted.