-
Notifications
You must be signed in to change notification settings - Fork 1
add domain to add item #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4022544
0450a64
0f67f5c
82e264b
f2c84b7
ba8932d
cb608bd
43fdb54
67d8997
4aad1ee
55f074a
4a88c09
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -23,9 +23,9 @@ async function saveLocalValue(tab, key, subKey = "", value) { | |||||
| return false; | ||||||
| } | ||||||
|
|
||||||
| async function saveCookieValue(tab, key, subKey = "", value) { | ||||||
| async function saveCookieValue(tab, key, subKey = "", domain, value) { | ||||||
| try { | ||||||
| return await chromeSaveCookieValue(tab, key, subKey, value); | ||||||
| return await chromeSaveCookieValue(tab, key, subKey, domain, value); | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This
Suggested change
WDYT?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At this point, I'm strongly inclined to include typescript in the project. I'm a bit resistant to make this change in this PR because by changing this, I feel like we would need to change local and session storage as well, which are out of scope for this PR. |
||||||
| } catch (e) { | ||||||
| console.log("🐶 ~ could not set cookie value for key " + key + " :", e); | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ function newItem({ storageType, item, actions }) { | |
| return [{ action: copyButton, visible: false }, { action: moreActionsButton }]; | ||
| } | ||
|
|
||
| function itemFooter({ id, key, subKey }) { | ||
| function itemFooter({ id, domain, key, subKey }) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side note: Following our design review about the badge & big values issue, we should review this component itemFooter. It's getting bigger and messy with new features.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand your concern. Create a new issue where we can properly address it: #104 |
||
| const footerBody = document.createElement("div"); | ||
| addClassesToElement(footerBody, "flex flex-col mb-2"); | ||
|
|
||
|
|
@@ -55,10 +55,15 @@ function newItem({ storageType, item, actions }) { | |
| keyDetailsArea.appendChild(keyLabel); | ||
|
|
||
| if (subKey) { | ||
| const subKeyLabel = newLabelWithBadge({ label: "Subkey", value: subKey || "" }); | ||
| const subKeyLabel = newLabelWithBadge({ label: "Subkey", value: subKey }); | ||
| keyDetailsArea.appendChild(subKeyLabel); | ||
| } | ||
|
|
||
| if (domain) { | ||
| const domainLabel = newLabelWithBadge({ label: "Domain", value: domain }); | ||
| keyDetailsArea.appendChild(domainLabel); | ||
| } | ||
|
|
||
| footerBody.appendChild(keyDetailsArea); | ||
|
|
||
| const tokenArea = newTextArea({ | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.