-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: add optional editable task titles #8689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review Complete ✅Re-reviewed the 6 new commits since the last review. After examining the implementation, tests, and integration points, I found no issues that require changes. SummaryThis PR successfully implements editable task titles with:
The implementation is production-ready and can be merged. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
…ow render without font-semibold
89c105b to
9765932
Compare
|
Rebased |
Related GitHub Issue
Closes: #8366
Description
This feature introduces editable titles for tasks, allowing users to label active work, persist those titles into task history, and search them—while providing a settings toggle and aligning the visual treatment across the UI.
Server↔️ Webview plumbing
HistoryItemwithtitleand updateClineProvider.updateTaskHistoryto merge partial updates so existing titles survive incremental syncs; explicitly allowundefinedto clear a title.setTaskTitlebranch inwebviewMessageHandlerthat normalizes/dedupes task IDs, trims/sanitizes the incoming title, skips no-op updates, persists viaupdateTaskHistory, and re-syncs the webview state.taskTitlesEnabledflag through extension messages/state and surface it to the webview context so both chat and history components react to the toggle.Webview UI
TaskHeader.tsx): introduce an inline editing experience (VS Code styled input, focus/keyboard handling, hover pencil) gated by the feature flag; when a title exists, display the text with standard weight instead of bolding.TaskItem.tsx): prefer titles when enabled, apply shared truncation/highlight behaviour, and render HTML highlights without the previousfont-semiboldclass so edited titles visually match default entries.useTaskSearch.ts): augment FZF selector to search titles + task prompts, split highlight ranges between title/task, and retain results ordering across sort modes.Settings & Telemetry
UISettingsthat toggles the new flag and emitsui_settings_task_titles_enabled_changed.Tests & Localization
Test Procedure
pnpm vitest webview-ui/src/components/chat/__tests__/TaskHeader.spec.tsxpnpm vitest webview-ui/src/components/history/__tests__/TaskItem.spec.tsxpnpm vitest webview-ui/src/components/history/__tests__/useTaskSearch.spec.tsxScreenshots / Videos
Documentation Updates
Important
Introduces editable task titles feature with UI support and settings toggle, including backend logic and tests.
taskTitlesEnabledflag inglobal-settings.tsandhistory.ts.ClineProviderto handle task title updates and sync with webview.setTaskTitleandsetTaskTitlesEnabledmessage types inwebviewMessageHandler.TaskHeader.tsx: Implements inline editing for task titles with a pencil icon, focus handling, and keyboard shortcuts.TaskItem.tsx: Displays task titles if enabled, with fallback to task text.UISettings.tsx: Adds checkbox to toggle task titles feature.TaskHeader.spec.tsx,TaskItem.spec.tsx, anduseTaskSearch.spec.tsxto cover new title editing and display logic.chat.jsonandsettings.json.This description was created by
for abf7eca. You can customize this summary. It will automatically update as commits are pushed.