Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 7, 2025

This PR contains the following updates:

Package Change Age Confidence
@types/react (source) 18.3.23 β†’ 18.3.27 age confidence

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this dependency update! However, I found an issue that needs to be addressed: the package.json files haven't been updated to match the lockfile changes.

@@ -241,10 +241,10 @@ importers:
version: 1.1.6
'@types/react':
specifier: ^18.3.23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile has been updated to use @types/react version 18.3.24, but the package.json files in the following locations still reference version ^18.3.23:

  • apps/web-evals/package.json (line 55)
  • webview-ui/package.json (line 91)
  • apps/web-roo-code/package.json (line 43)

Could you please update these package.json files to specify "@types/react": "^18.3.24" to maintain consistency between the package manifests and the lockfile? This inconsistency could lead to version conflicts and unexpected behavior.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 7, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Sep 9, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 9, 2025
@renovate renovate bot force-pushed the renovate/react-monorepo branch from a02fd83 to e895bb1 Compare September 11, 2025 20:24
@daniel-lxs daniel-lxs moved this from PR [Needs Review] to Renovate BOT in Roo Code Roadmap Sep 16, 2025
@renovate renovate bot force-pushed the renovate/react-monorepo branch 16 times, most recently from e1e81d6 to 5ee444b Compare September 27, 2025 02:51
@renovate renovate bot force-pushed the renovate/react-monorepo branch from 697b0f0 to f9d24d5 Compare October 6, 2025 15:37
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot changed the title chore(deps): update dependency @types/react to v18.3.25 chore(deps): update dependency @types/react to v18.3.26 Oct 6, 2025
@renovate renovate bot force-pushed the renovate/react-monorepo branch from f9d24d5 to 7333e8c Compare October 6, 2025 21:10
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some issues that need attention. See inline comment(s).

@@ -241,10 +241,10 @@ importers:
version: 1.1.6
'@types/react':
specifier: ^18.3.23
version: 18.3.23
version: 18.3.26
'@types/react-dom':
specifier: ^18.3.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Inconsistent @types/react-dom specifiers across workspaces. The lockfile resolves to 18.3.7, but package.json manifests specify different ranges: apps/web-evals and webview-ui use ^18.3.5 while apps/web-roo-code uses ^18.3.7. Recommend aligning all manifests to ^18.3.7 (or a single ^18.3.x) to avoid drift and ensure consistent installs: - apps/web-evals/package.json line 56 -> "@types/react-dom": "^18.3.7" - webview-ui/package.json line 94 -> "@types/react-dom": "^18.3.7" - apps/web-roo-code/package.json line 46 is already ^18.3.7.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 7333e8c to 7fb0982 Compare October 7, 2025 21:51
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 7fb0982 to bab7d4c Compare October 8, 2025 01:39
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found - all concerns already addressed in existing comments.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from bab7d4c to 110941d Compare October 9, 2025 03:57
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous review incorrectly identified an issue with package.json files not being updated. This is actually correct behavior: the package.json files specify ^18.3.23 for @types/react, which means 'compatible with 18.3.23'. The lockfile correctly resolves this to 18.3.26, which is a valid patch update within the semver range. No package.json changes are needed for this type of dependency update.

@renovate renovate bot force-pushed the renovate/react-monorepo branch from 110941d to 8ac5a34 Compare October 21, 2025 10:08
@roomote
Copy link
Contributor

roomote bot commented Oct 21, 2025

Rooviewer Clock Β Β Follow along on Roo Cloud

Review Complete

This PR correctly updates @types/react from 18.3.23 to 18.3.27 in the lockfile. The dependency update itself is valid and all resolved versions are consistent.

No new actionable issues were found in this update. The 3 previously flagged issues remain valid but are minor version management suggestions that don't affect functionality:

  • Package.json files could be updated to explicitly reference the resolved version (currently using ^18.3.23 which correctly resolves to 18.3.27)
  • Transitive dependency @types/prop-types was bumped from 15.7.14 to 15.7.15 as expected
  • @types/react-dom specifiers vary across workspaces (^18.3.5 vs ^18.3.7) but all resolve correctly to 18.3.7
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@renovate renovate bot force-pushed the renovate/react-monorepo branch 2 times, most recently from ee66584 to cc7e0c2 Compare November 10, 2025 16:47
@renovate renovate bot force-pushed the renovate/react-monorepo branch from cc7e0c2 to dd3f96a Compare November 11, 2025 01:04
@renovate renovate bot changed the title chore(deps): update dependency @types/react to v18.3.26 chore(deps): update dependency @types/react to v18.3.27 Nov 18, 2025
@renovate renovate bot force-pushed the renovate/react-monorepo branch from dd3f96a to 34744c7 Compare November 18, 2025 02:51
@renovate renovate bot force-pushed the renovate/react-monorepo branch from 34744c7 to 55faa2f Compare November 18, 2025 14:47
@renovate renovate bot force-pushed the renovate/react-monorepo branch from 55faa2f to b1fe767 Compare November 22, 2025 08:07
@renovate renovate bot force-pushed the renovate/react-monorepo branch from b1fe767 to c317048 Compare December 3, 2025 16:02
@renovate renovate bot force-pushed the renovate/react-monorepo branch from c317048 to 166091e Compare December 31, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Renovate BOT

Development

Successfully merging this pull request may close these issues.

2 participants