perf: add early termination to fuzzySearch for CPU optimization #10484
+22
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #9750
Description
This PR attempts to address the high CPU load issue reported in #9750. After analyzing the CPU profile attached by @jola16, I identified the performance bottleneck in the
fuzzySearchfunction.Root Cause:
The
fuzzySearchfunction performs a middle-out search that calculates Levenshtein distance (O(m*n) per comparison) for every position in the search range, even after finding a perfect match.Solution:
Added early termination optimization: when a perfect match (similarity === 1) is found, the function now returns immediately instead of continuing to iterate through all positions.
Files Modified:
src/core/diff/strategies/multi-search-replace.tssrc/core/diff/strategies/multi-file-search-replace.tsThis optimization significantly reduces CPU usage when exact matches are found early in the search.
Test Procedure
multi-search-replace.spec.ts(60 tests)multi-file-search-replace-8char.spec.ts(9 tests)To verify the fix:
Pre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome! This is an attempt to address the performance issue.