-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: Add centralized HTTP client configuration for Bedrock proxy/SSL support #10428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
pballou
wants to merge
8
commits into
RooCodeInc:main
from
pballou:cursor/bedrock-http-handling-cleanup-342c
Closed
feat: Add centralized HTTP client configuration for Bedrock proxy/SSL support #10428
pballou
wants to merge
8
commits into
RooCodeInc:main
from
pballou:cursor/bedrock-http-handling-cleanup-342c
+319
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new `utils/http-client.ts` module to manage proxy, CA, and SSL settings consistently across the application. This includes updates to various providers and fetchers to utilize the new configuration. Co-authored-by: patrickat4.8 <patrickat4.8@gmail.com>
Co-authored-by: patrickat4.8 <patrickat4.8@gmail.com>
Co-authored-by: patrickat4.8 <patrickat4.8@gmail.com>
7 tasks
Contributor
Review completed. No issues found. The incremental change from the merge with main adds a defensive type check (
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
New feature or request
Issue/PR - Triage
New issue. Needs quick review to confirm validity and assign labels.
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #4446 and #8184
Description
This PR introduces a centralized HTTP client configuration utility to resolve proxy and SSL certificate verification issues with the AWS Bedrock provider.
Key Changes:
New Centralized HTTP Client Utility (
src/utils/http-client.ts):HTTPS_PROXY/HTTP_PROXY/ALL_PROXYenv vars and VS Code settings)NODE_EXTRA_CA_CERTS,AWS_CA_BUNDLE)http.proxyStrictSSL)NO_PROXYpatternsBedrock Provider Integration:
src/api/providers/bedrock.tsto usegetRooNodeHttpHandler()src/services/code-index/embedders/bedrock.tsfor consistent behaviorDesign Decisions:
requestHandlerconfiguration to ensure consistent behavior across all Bedrock operationsrequestTimeout: 0to avoid SDK timeouts conflicting with application-level timeout handlingWhat This PR Does NOT Change:
Test Procedure
Manual Testing:
Unit Test Coverage:
Environment Tested:
Pre-Submission Checklist
Get in Touch
Discord: pattywaggon
Important
Introduces centralized HTTP client configuration for AWS Bedrock provider, handling proxy and SSL settings via a new utility in
http-client.ts.http-client.ts):HTTPS_PROXY,HTTP_PROXY,ALL_PROXY, and VS Code settings.NODE_EXTRA_CA_CERTSandAWS_CA_BUNDLE.http.proxyStrictSSL.NodeHttpHandlerfor AWS SDK v3.NO_PROXYpatterns.bedrock.tsandembedders/bedrock.tsto usegetRooNodeHttpHandler().@smithy/node-http-handlerandproxy-agenttopackage.json.This description was created by
for 5a98ad4. You can customize this summary. It will automatically update as commits are pushed.