feat(modes): add regex scoped read permissions per mode + orchestrator skills read allowlist

[hannesrudolph]

Summary

• Enforce fileRegex on the read group for the read_file tool (native { files: [...] } payloads).
• Update FileRestrictionError to support read vs edit wording.
• Restrict built-in Orchestrator mode so it can only read skill definition SKILL.md files, supporting both:
  • workspace-relative: .roo/skills(-<mode>)/<skill>/SKILL.md
  • absolute/global paths (and Windows-style separators): /Users/<user>/.roo/skills(-<mode>)/<skill>/SKILL.md / C:\\Users\\<user>\\.roo\\skills(-<mode>)\\<skill>\\SKILL.md

Key changes

• Native args used for tool validation: src/core/assistant-message/presentAssistantMessage.ts
• Read restriction enforcement: src/core/tools/validateToolUse.ts
• Skills <location> uses absolute paths: src/core/prompts/sections/skills.ts
• Orchestrator allowlist (absolute + relative): packages/types/src/mode.ts

Tests

• cd src && npx vitest run shared/__tests__/modes.spec.ts

Notes

• Behavior is unchanged unless a mode sets fileRegex on the read group.
• Orchestrator remains constrained to skill definition reads only; this update makes the allowlist compatible with absolute skill paths.

[roomote]

Oroocle   Follow along on Roo Cloud

Re-review complete. No outstanding issues found.

• Ensure read_file fileRegex enforcement also handles cases where toolParams.files is a JSON string (not an array) so restrictions cannot be skipped.

Previous reviews

• 0e9286e: Review #1
• 2490135: Review #2
• 4e46243: Review #3
• b03cf69: Review #4

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[hannesrudolph]

Fixed: read_file fileRegex enforcement now also validates when toolParams.files is a JSON string. Added tests for both allowed/blocked JSON-string payloads.\n\nChanges:\n- src/core/tools/validateToolUse.ts\n- src/core/tools/tests/validateToolUse.spec.ts

[mrubens]

This feels like a lot - is this what we do for the edit file regex too? Could we just share that code?

[hannesrudolph]

@roomote follow this suggestion

[roomote]

Fixaroo   See task on Roo Cloud

Refactored XML path extraction into shared extractPathsFromXmlArgs() function used by both edit and read file regex validation. All local checks passed.

_{View commit | Revert commit}