Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Dec 30, 2025

Summary

Align Roo's Agent Skills implementation with the official Agent Skills specification (https://agentskills.io/specification) so we can be listed as a supported tool.

Spec coverage (frontmatter fields)

Table adapted from the official specification docs.

Field Required Constraints (per spec) Before After Notes
name Yes Max 64 characters. Lowercase letters, numbers, and hyphens only. Must not start or end with a hyphen. Must not contain consecutive hyphens (--). Must match the parent directory name. ⚠️ After: strictly validated during discovery in SkillsManager.
description Yes Max 1024 characters. Non-empty. Describes what the skill does and when to use it. ⚠️ After: strictly validated during discovery in SkillsManager.
license No License name or reference to a bundled license file. Not parsed/stored today.
compatibility No Max 500 characters. Environment requirements. Not parsed/stored today.
metadata No Arbitrary key-value mapping. Not parsed/stored today.
allowed-tools No Space-delimited list of pre-approved tools. (Experimental) Not parsed/stored today.

Legend: ✅ implemented, ❌ not implemented, ⚠️ partially implemented (accepted non-spec values / not strict)

Changes

Spec alignment (⚠️ → ✅ in the table above)

  • Enforce strict spec validation for skill name during discovery (1–64 chars; lowercase alnum + hyphens; no leading/trailing hyphen; no consecutive hyphens; must match directory name).
  • Enforce strict spec validation for skill description during discovery (trimmed, non-empty; max 1024 chars).

Implementation improvements

  • Emit <available_skills> XML in the prompt section (with proper XML escaping).
  • Use absolute SKILL.md paths in <location> for filesystem-based agents.
  • Add/expand automated tests covering prompt XML output + strict validation behavior.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Dec 30, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 30, 2025

Oroocle Clock   See task on Roo Cloud

Re-review complete. No new issues found in the latest update.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 30, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from roomote’s comment

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2025
@hannesrudolph hannesrudolph merged commit ed13921 into main Dec 30, 2025
10 checks passed
@hannesrudolph hannesrudolph deleted the sync-to-official-skills-spec branch December 30, 2025 22:35
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 30, 2025
@roomote roomote bot mentioned this pull request Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants