fix: checkpoint restore uses current task service before cancellation #10404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #10402 where checkpoint restore was not working properly.
Problem
The checkpoint restore was failing because the
checkpointRestoremessage handler inwebviewMessageHandler.tscalledcancelTask()BEFORE callingcheckpointRestore(). This sequence caused:cancelTask()destroyed the current task with its initialized checkpoint servicecheckpointRestore()was called on the new task,getCheckpointService()returnedundefinedSolution
Call
checkpointRestore()directly on the current task (before any cancellation), which already has its checkpoint service properly initialized. ThecheckpointRestorefunction insrc/core/checkpoints/index.tsalready handles callingcancelTask()internally at the end to reinitialize the UI.Changes
cancelTask()call incheckpointRestoremessage handlercheckpointRestore()on the current task directlypWaitForimportTesting
Feedback and guidance are welcome!