-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix rate limit wait display #10389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rate limit wait display #10389
Conversation
Re-review complete. No net new issues found; 1 previously flagged item remains.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| "streaming": "Permintaan API...", | ||
| "cancelled": "Permintaan API Dibatalkan", | ||
| "streamingFailed": "Streaming API Gagal", | ||
| "rateLimitWait": "Pembatasan rate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical note: The new string "Pembatasan rate" mixes Indonesian with English. Consider localizing "rate" (e.g., "Pembatasan laju" or "Batasan kecepatan") to maintain consistency with the rest of the translations.
| "rateLimitWait": "Pembatasan rate", | |
| "rateLimitWait": "Pembatasan laju", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
User-configured rate limiting is not an error/retry signal and should not mark the API as unstable in eval runner.
Changed the rate limit wait countdown from a hardcoded English string to a structured JSON payload for i18n-safe transport. The frontend ChatRow component now parses the JSON to extract the seconds value, enabling proper internationalization through the existing rateLimitWait translation key.
Fixed the indentation issue in the |
|
I think passing JSON is better than parsing the English string, but I'm on my phone and haven't tested to make sure the latest commit works. |
|
@roomote fix the test. We hide the row now when the rate limiting is complete. |
Fixed the test to verify the rate limit row is hidden when complete. All local tests passed. |
Fixes user-configured rate limiting (client-side throttling in the extension) being surfaced as a Provider Error.
Before


AFTER


Important
Fixes rate limit wait display by introducing
api_req_rate_limit_waitstatus and updating task handling and UI components.api_req_rate_limit_waitas a non-error status inrunTask.tsandmessage.ts.api_req_startedemission until after rate-limit wait inTask.tsto prevent overlapping spinners.ChatRow.tsx.ChatRow.tsxandChatView.tsxto handleapi_req_rate_limit_waitstatus.ChatRow.rate-limit-wait.spec.tsxfor testing rate limit wait display.rateLimitWaitstring to multiple locale files for i18n support.Task.spec.tsto verify rate limit wait behavior and message emission.This description was created by
for 37bc97b. You can customize this summary. It will automatically update as commits are pushed.