-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore: remove human-relay provider #10388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review updated. All previously flagged items look resolved in the latest commit.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| "unregisterHumanRelayCallback", | ||
| "handleHumanRelayResponse", | ||
|
|
||
| "newTask", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/vscode-e2e/src/suite/extension.test.ts still expects the Human Relay commands (showHumanRelayDialog, etc). Since those commands were removed from commandIds here, the e2e test will likely fail until the expected command list is updated.
Fix it with Roo Code or mention @roomote and request a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roomote fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixaroo
See task on Roo Cloud
Fixed the reported issues. All local checks passed.
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as long as you confirmed the behavior for what happens to people who have the human relay provider selected when it goes away (just want to make sure the extension doesn’t crash the way it used to)
Summary
Removes the Human Relay provider and all related UI/extension plumbing as this provider does not operate with native tool calling.
Changes
Important
Remove Human Relay provider and all related components, including API handlers, UI elements, message types, and translations.
index.ts.App.tsx.extension.test.tsandvscode.ts.provider-settings.tsand related schemas.ProfileValidatorinProfileValidator.ts.locales/ca/humanRelay.jsonandlocales/de/humanRelay.json.This description was created by
for 5432f10. You can customize this summary. It will automatically update as commits are pushed.