ci: upload maestro junit reports and full test artifacts#7332
Closed
diegolmello wants to merge 1 commit into
Closed
ci: upload maestro junit reports and full test artifacts#7332diegolmello wants to merge 1 commit into
diegolmello wants to merge 1 commit into
Conversation
The iOS / Android Maestro workflows only uploaded *.png under ~/.maestro/tests. JUnit XML (maestro-report.xml, maestro-rerun-round-*.xml) and Maestro's per-flow command logs were discarded, so a CI failure surfaced only as a screenshot of the final state, not the failing step or step trace. Expand the upload-artifact globs on both workflows to include the JUnit reports (in CWD) and the full ~/.maestro/tests tree.
diegolmello
requested a deployment
to
approve_e2e_testing
GitHub Actions
Waiting
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📜 Recent review details🔇 Additional comments (2)
WalkthroughMaestro test workflows for Android and iOS are updated to collect expanded artifact sets: all files under ChangesMaestro Artifact Collection Expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
requested a deployment
to
official_ios_build
GitHub Actions
Waiting
diegolmello
requested a deployment
to
official_android_build
GitHub Actions
Waiting
diegolmello
requested a deployment
to
experimental_ios_build
GitHub Actions
Waiting
diegolmello
requested a deployment
to
experimental_android_build
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The iOS / Android Maestro workflows only uploaded
*.pngunder~/.maestro/tests. JUnit XML reports (maestro-report.xml,maestro-rerun-round-*.xmlproduced in CWD by.github/scripts/run-maestro.sh) and Maestro's per-flow command logs and recordings were discarded, so a CI failure surfaced only as a screenshot of the final state — not the failing step name, not the step trace.This made shard-level flakes (e.g. the recurring
deeplink.yaml → helpers/create-account.yamlusername-field flake on iOS shard 6) almost undiagnosable from CI artifacts alone.This PR expands the
upload-artifactglobs on bothmaestro-ios.ymlandmaestro-android.ymlto include:~/.maestro/tests/**/*(PNGs as before, pluscommands.log, recordings, etc.)maestro-report.xml,maestro-rerun-round-*.xmlIssue(s)
Motivated by the recurring shard 6 iOS deeplink failure on #7311.
How to test or reproduce
maestro-ios.ymlandmaestro-android.yml.iOS Maestro Logs - Shard N/Android Maestro Logs - Shard Nartifacts should now contain the JUnit XML(s) and any per-flow logs in addition to the screenshots.Screenshots
N/A — CI workflow change only.
Types of changes
Checklist
Summary by CodeRabbit