Skip to content

feat(voip): introduce CallLifecycle.answerIncoming and beginOutgoing #7276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegolmello wants to merge 5 commits into
base: voip-refactor/04-voip-native-attach-and-cold-start
Choose a base branch
from
Open

feat(voip): introduce CallLifecycle.answerIncoming and beginOutgoing #7276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
791dd74
feat(voip): introduce CallLifecycle.answerIncoming and beginOutgoing
diegolmello Apr 29, 2026
ee1639d
refactor(voip): collapse setCall and setCallStateOnly into a single s…
diegolmello Apr 30, 2026
c5139f4
fix(voip): make CallLifecycle.answerIncoming idempotent under concurr…
diegolmello Apr 30, 2026
cca6785
fix(voip): restore outgoing DM lookup in beginOutgoing for username-i…
diegolmello Apr 30, 2026
b4e34a8
fix(voip): swallow DM lookup errors so callBegan still emits
diegolmello Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { usePeerAutocompleteStore } from '../../lib/services/voip/usePeerAutocom
import { useCallStore } from '../../lib/services/voip/useCallStore';
import { mediaSessionInstance } from '../../lib/services/voip/MediaSessionInstance';
import { voipNative, type InMemoryVoipNative } from '../../lib/services/voip/VoipNative';
import { CallNavRouter } from '../../lib/services/voip/CallNavRouter';
import { mockedStore } from '../../reducers/mockedStore';
import type { TPeerItem } from '../../lib/services/voip/getPeerAutocompleteOptions';
import type { InsideStackParamList } from '../../stacks/types';
Expand Down Expand Up @@ -53,7 +54,7 @@ jest.mock('../../lib/methods/helpers/helpers', () => ({
}));
jest.mock('../../lib/navigation/appNavigation', () => ({
__esModule: true,
default: { navigate: jest.fn(), back: jest.fn() },
default: { navigate: jest.fn(), back: jest.fn(), getCurrentRoute: jest.fn(), navigationRef: { current: {} } },
waitForNavigationReady: jest.fn().mockResolvedValue(undefined)
}));
jest.mock('../../lib/services/sdk', () => ({
Expand Down Expand Up @@ -388,6 +389,11 @@ describe('VoIP call lifecycle (integration)', () => {
useCallStore.getState().reset();
mediaSessionInstance.reset();
(voipNative as InMemoryVoipNative).reset();
// Mount CallNavRouter so callBegan → Navigation.navigate('CallView') fires.
// Navigation.navigationRef.current is set to {} (truthy) in the mock above,
// so the router subscribes immediately without waiting for navigationReady.
CallNavRouter.unmount();
CallNavRouter.mount();

consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation((...args: unknown[]) => {
const message = formatConsoleArgs(args);
Expand All @@ -408,6 +414,7 @@ describe('VoIP call lifecycle (integration)', () => {
});

afterEach(() => {
CallNavRouter.unmount();
consoleErrorSpy?.mockRestore();
consoleWarnSpy?.mockRestore();
consoleErrorSpy = undefined;
Expand Down Expand Up @@ -447,6 +454,11 @@ describe('VoIP call lifecycle (integration)', () => {

const { call } = useCallStore.getState();
expect(call?.callId).toBe('call-user-1');
// Pre-refactor parity: outgoing DM-by-username has no roomId from the caller, so
// CallLifecycle.beginOutgoing falls back to getDMSubscriptionByUsername. The mock
// here returns null (no DM subscription) AND the synthetic call has no contact
// username, so roomId stays null — but the lookup path must remain wired.
expect(useCallStore.getState().roomId).toBeNull();

// Firing 'ended' triggers CallLifecycle teardown via the handleEnded listener.
// Navigation.back() is now handled by CallNavRouter (not wired in this integration test).
Expand Down
Loading