-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: new test workspace #6841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d8ac7ff
fe0ac85
f6094e7
951d958
97e5dae
1e47fcf
552e5f9
39c4230
1c83f70
2fd8aeb
e430444
e4f590c
60c9ecd
d2ae7ae
06fc387
6f13320
ee9c1c8
5f5ebc8
d1c8b0d
5bca91a
adff051
f337490
9416f66
457adb6
9339a40
d38241e
0966f82
c5cea73
5ba4944
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,8 +93,20 @@ tags: | |
| visible: | ||
| text: '.*Delete.*' | ||
| timeout: 60000 | ||
| - tapOn: | ||
| text: 'Delete' | ||
| - runFlow: | ||
| when: | ||
| platform: iOS | ||
| commands: | ||
| - tapOn: | ||
| point: 65%,55% | ||
| retryTapIfNoChange: true | ||
| - runFlow: | ||
| when: | ||
| platform: Android | ||
| commands: | ||
| - tapOn: | ||
| text: 'Delete' | ||
| retryTapIfNoChange: true | ||
|
Comment on lines
+96
to
+109
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Coordinate-based taps are fragile across device configurations. Same concern as in changeserver.yaml: the iOS flow uses hardcoded coordinates 🤖 Prompt for AI Agents |
||
| - waitForAnimationToEnd: | ||
| timeout: 300 | ||
| - extendedWaitUntil: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use text or accessibility identifier-based selectors instead of coordinates for cross-device compatibility.
The iOS flow's hardcoded coordinates
(65%, 55%)are device-dependent and may fail on different screen sizes or resolutions. The Android flow already uses the superiortext: 'Delete'selector. Consider whether the Delete button has an accessibility identifier and update both flows consistently:Note:
retryTapIfNoChangeaddresses timing issues with screen hierarchy changes, not coordinate fragility.🤖 Prompt for AI Agents