fix: add Cmd+, shortcut to open Preferences on macOS#3340
Conversation
Add standard macOS Preferences menu item with 'Command+,' accelerator in the app menu. Opens the Settings view, matching existing behavior. - Add 'preferences' translation key - Insert Preferences item in macOS app menu between About and Services - Uses standard Electron 'Command+,' accelerator - macOS-only (inside process.platform === 'darwin' block)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🔇 Additional comments (2)
WalkthroughThis PR adds a native macOS Preferences menu item to the application menu. A new translation key ChangesmacOS Preferences Menu
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Adds the standard macOS keyboard shortcut Cmd+, (Command+Comma) to open Preferences/Settings. This is a universal macOS convention — most native apps support it.
Changes
menus.preferences→"Preferences"translation keyprocess.platform === 'darwin'block) with:Command+,SIDE_BAR_SETTINGS_BUTTON_CLICKED(same as clicking Settings in the sidebar)Menu order (macOS only)
Testing checklist
Command+,is not used by any other menu itemprocess.platform === 'darwin'block)en.i18n.jsonCloses #3325
Summary by CodeRabbit