fix(i18n): fix zh-TW mixing Simplified Chinese characters and add missing keys#3307
fix(i18n): fix zh-TW mixing Simplified Chinese characters and add missing keys#3307dwakshar wants to merge 2 commits into
Conversation
- Added missing keys: downloads, videoCall, mediaPermission, microphonePermissionDenied, sidebar extras (clearCache, clearStorageData, downloads, settings), disableGpu, helpMenu - Fixed Simplified terms: 設置→設定, 攝像頭→攝影機, 視頻→影片, 屏幕→螢幕, 消息→訊息, 搜索→搜尋, 網絡→網路 - Fixed touchBar formatting key (was untranslated) - Ensured all terminology follows Taiwan standard zh-TW conventions Fixes RocketChat#3306
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Traditional Chinese (zh-TW) translation file to add new UI text for media permission dialogs, downloads, video call states, and new settings/menu entries; also corrected Taiwan-specific terminology and adjusted several existing labels. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/i18n/zh-TW.i18n.json`:
- Around line 135-145: The translation for the key downloads.item.errored
currently reads "下載已取消" which indicates cancellation but is used by
DownloadItem.tsx for error states; update the value of "item.errored" under the
downloads namespace to an error-state phrasing such as "下載失敗" or "下載發生錯誤" so it
accurately reflects a failed download instead of a cancelled one and ensure
DownloadItem.tsx continues to reference downloads.item.errored.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6bf33d58-9e57-46e7-8f2c-891c43b6ea50
📒 Files selected for processing (1)
src/i18n/zh-TW.i18n.json
📜 Review details
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Ram-sah19
Repo: RocketChat/Rocket.Chat.Electron PR: 3254
File: .github/workflows/build-release.yml:80-94
Timestamp: 2026-03-11T06:38:40.426Z
Learning: In the RocketChat/Rocket.Chat.Electron repository, the issues flagged in `.github/workflows/build-release.yml` (e.g., `node12` runtime in the release action and missing `snapcraft_token` input), i18n files, and `electron-builder.json` are pre-existing in the `develop` branch and are pulled in during merge conflict resolution. Do not flag these as new issues introduced by PRs that only modify `src/injected.ts` and `src/ui/main/rootWindow.ts`.
- Added missing keys: downloads, videoCall, mediaPermission, microphonePermissionDenied, sidebar extras (clearCache, clearStorageData, downloads, settings), disableGpu, helpMenu - Fixed Simplified terms: 設置→設定, 攝像頭→攝影機, 視頻→影片, 屏幕→螢幕, 消息→訊息, 搜索→搜尋, 網絡→網路 - Fixed touchBar formatting key (was untranslated) - Ensured all terminology follows Taiwan standard zh-TW conventions Fixes RocketChat#3306
dwakshar
left a comment
There was a problem hiding this comment.
下載失敗 → simple, standard, widely used ✅
Noticed this while going through the Electron app with zh-TW set — a bunch of UI strings were either showing up in Simplified Chinese or just falling back to English because the keys didn't exist in the zh-TW file at all. Figured I'd fix both problems in one go.
The Two Issues
Changes
Screenshots (After)
The previous version showed mixed Simplified Chinese or English fallback
for these sections. Below are the corrected zh-TW translations after the fix.
Settings
Context menu
Fixes #3306
Summary by CodeRabbit
New Features
Documentation