Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/definition/accessors/ILivechatCreator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface ILivechatCreator {
* @param visitor The Livechat Visitor that started the conversation
* @param agent The agent responsible for the room
*/
createRoom(visitor: IVisitor, agent: IUser, extraParams?: IExtraRoomParams): Promise<ILivechatRoom>;
createRoom(visitor: IVisitor, agent?: IUser, extraParams?: IExtraRoomParams): Promise<ILivechatRoom>;
/**
* Creates a Livechat visitor
*
Expand Down
4 changes: 2 additions & 2 deletions src/server/accessors/LivechatCreator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import { AppBridges } from '../bridges';
export class LivechatCreator implements ILivechatCreator {
constructor(private readonly bridges: AppBridges, private readonly appId: string) { }

public createRoom(visitor: IVisitor, agent: IUser, extraParams?: IExtraRoomParams): Promise<ILivechatRoom> {
return this.bridges.getLivechatBridge().doCreateRoom(visitor, agent, this.appId, extraParams);
public createRoom(visitor: IVisitor, agent?: IUser, extraParams?: IExtraRoomParams): Promise<ILivechatRoom> {
return this.bridges.getLivechatBridge().doCreateRoom(visitor, this.appId, agent, extraParams);
}

public createVisitor(visitor: IVisitor): Promise<string> {
Expand Down
6 changes: 3 additions & 3 deletions src/server/bridges/LivechatBridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ export abstract class LivechatBridge extends BaseBridge {
}
}

public async doCreateRoom(visitor: IVisitor, agent: IUser, appId: string, extraParams?: IExtraRoomParams): Promise<ILivechatRoom> {
public async doCreateRoom(visitor: IVisitor, appId: string, agent?: IUser, extraParams?: IExtraRoomParams): Promise<ILivechatRoom> {
if (this.hasWritePermission(appId, 'livechat-room')) {
return this.createRoom(visitor, agent, appId, extraParams);
return this.createRoom(visitor, appId, agent, extraParams);
}
}

Expand Down Expand Up @@ -174,7 +174,7 @@ export abstract class LivechatBridge extends BaseBridge {
protected abstract findVisitorByToken(token: string, appId: string): Promise<IVisitor | undefined>;
protected abstract findVisitorByPhoneNumber(phoneNumber: string, appId: string): Promise<IVisitor | undefined>;
protected abstract transferVisitor(visitor: IVisitor, transferData: ILivechatTransferData, appId: string): Promise<boolean>;
protected abstract createRoom(visitor: IVisitor, agent: IUser, appId: string, extraParams?: IExtraRoomParams): Promise<ILivechatRoom>;
protected abstract createRoom(visitor: IVisitor, appId: string, agent?: IUser, extraParams?: IExtraRoomParams): Promise<ILivechatRoom>;
protected abstract closeRoom(room: ILivechatRoom, comment: string, closer: IUser | undefined, appId: string): Promise<boolean>;
protected abstract findRooms(visitor: IVisitor, departmentId: string | null, appId: string): Promise<Array<ILivechatRoom>>;
protected abstract findDepartmentByIdOrName(value: string, appId: string): Promise<IDepartment | undefined>;
Expand Down
2 changes: 1 addition & 1 deletion tests/test-data/bridges/livechatBridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class TestLivechatBridge extends LivechatBridge {
public findVisitorByPhoneNumber(phoneNumber: string, appId: string): Promise<IVisitor | undefined> {
throw new Error('Method not implemented');
}
public createRoom(visitor: IVisitor, agent: IUser, appId: string, extraParams?: IExtraRoomParams): Promise<ILivechatRoom> {
public createRoom(visitor: IVisitor, appId: string, agent?: IUser, extraParams?: IExtraRoomParams): Promise<ILivechatRoom> {
throw new Error('Method not implemented');
}
public closeRoom(room: ILivechatRoom, comment: string, closer: IUser | undefined, appId: string): Promise<boolean> {
Expand Down