Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/definition/accessors/IModifyDeleter.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export interface IModifyDeleter {
deleteRoom(roomId: string): Promise<void>;
deleteMessage(messageId: string): Promise<void>;
}
4 changes: 4 additions & 0 deletions src/server/accessors/ModifyDeleter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,8 @@ export class ModifyDeleter implements IModifyDeleter {
public async deleteRoom(roomId: string): Promise<void> {
return this.bridges.getRoomBridge().doDelete(roomId, this.appId);
}

public async deleteMessage(messageId: string): Promise<void> {
return this.bridges.getMessageBridge().doDelete(messageId, this.appId);
}
}
19 changes: 19 additions & 0 deletions src/server/bridges/MessageBridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,19 @@ export abstract class MessageBridge extends BaseBridge {
return this.getById(messageId, appId);
}
}
public async doDelete(messageId: string, appId: string): Promise<void> {
if (this.hasDeletePermission(appId)) {
return this.delete(messageId, appId);
}
}

protected abstract create(message: IMessage, appId: string): Promise<string>;
protected abstract update(message: IMessage, appId: string): Promise<void>;
protected abstract notifyUser(user: IUser, message: IMessage, appId: string): Promise<void>;
protected abstract notifyRoom(room: IRoom, message: IMessage, appId: string): Promise<void>;
protected abstract typing(options: ITypingDescriptor, appId: string): Promise<void>;
protected abstract getById(messageId: string, appId: string): Promise<IMessage>;
protected abstract delete(messageId: string, appId: string): Promise<void>;

private hasReadPermission(appId: string): boolean {
if (AppPermissionManager.hasPermission(appId, AppPermissions.message.read)) {
Expand All @@ -80,4 +86,17 @@ export abstract class MessageBridge extends BaseBridge {

return false;
}

private hasDeletePermission(appId: string): boolean {
if (AppPermissionManager.hasPermission(appId, AppPermissions.message.delete)) {
return true;
}

AppPermissionManager.notifyAboutError(new PermissionDeniedError({
appId,
missingPermissions: [AppPermissions.message.delete],
}));

return false;
}
}
2 changes: 2 additions & 0 deletions src/server/permissions/AppPermissions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const AppPermissions = {
'message': {
read: { name: 'message.read' },
write: { name: 'message.write' },
delete: { name: 'message.delete'},
},
'livechat-status': {
read: { name: 'livechat-status.read' },
Expand Down Expand Up @@ -101,6 +102,7 @@ export const defaultPermissions: Array<IPermission> = [
AppPermissions.room.write,
AppPermissions.message.read,
AppPermissions.message.write,
AppPermissions.message.delete,
AppPermissions['livechat-department'].read,
AppPermissions['livechat-department'].write,
AppPermissions['livechat-room'].read,
Expand Down
3 changes: 3 additions & 0 deletions tests/test-data/bridges/messageBridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,7 @@ export class TestsMessageBridge extends MessageBridge {
public typing(options: ITypingDescriptor): Promise<void> {
throw new Error('Method not implemented.');
}
public delete(messageId: string, appId: string): Promise<void> {
throw new Error('Method not implemented.');
}
}