fix(react): unsubscribe onAuthChange listeners and prevent race conditions#1199
Open
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Open
fix(react): unsubscribe onAuthChange listeners and prevent race conditions#1199deepak0x wants to merge 2 commits intoRocketChat:developfrom
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Conversation
…back is still registered after await
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a memory leak in the React components where
onAuthChangelisteners were registered inuseEffecthooks but never unsubscribed in the cleanup phase. Additionally, it adds a check inRocketChatAuth.tsto prevent a race condition where a callback might be executed after it has been unsubscribed.Changes
onAuthChangecallbacks to named functions and addedremoveAuthListenerinuseEffectcleanup.onAuthChangeto verify the callback is still registered after the asyncgetCurrentUsercall.Fixes #1198