Fix messaging bugs, add tests, CI, and project docs by Rochet2 · Pull Request #27 · Rochet2/AIO

Rochet2 · 2026-05-31T04:30:38Z

Summary

Fix queue clear, server cache timing (milliseconds), stored-byte accounting, debug.sethook cleanup, reset persistence, Windows path basenames, version mismatch handling, and related messaging bugs
Add aio_util.lua helpers, 24 unit tests, GitHub Actions CI (tests + Luacheck + sync checks), and project docs (SECURITY.md, DEPENDENCIES.md, tooling config)
Make AIO_FORCE_RELOAD_ON_STARTUP configurable (default true); fix typos in README and API comments

Test plan

Run lua5.1 tests/run.lua locally (24 tests)
Verify CI passes on this PR
Test in-game: client init, addon push, long messages, /aio reset, ForceReset from server
Confirm server script reload respects AIO_FORCE_RELOAD_ON_STARTUP

Correct server cache timing, stored-byte accounting, sethook cleanup, reset persistence, and Windows path basenames; add aio_util helpers, unit tests, Luacheck CI, and SECURITY/DEPENDENCIES docs.

Ubuntu Noble has no luacheck apt package; install with luarocks instead. Bump actions/checkout to v5 for Node.js 24 runner support.

Example addons use many WoW globals and are not plain Lua; scope luacheck to core modules and tests.

Lint core modules and tests strictly; run syntax-only checks on the AIO monolith. Pin luarocks to Lua 5.1 and rename a time-diff parameter for parser compatibility.

CRLF files caused luacheck trailing-whitespace failures on Linux CI runners.

Install Lua 5.1 and luacheck via leafo actions; lint queue/aio_util strictly and syntax-check AIO.lua and tests with lua -p.

Ubuntu Noble has no luacheck apt package; use luarocks instead. Use project config so scoped lint passes (no-config treated warnings as failures).

Per-file globals replaced the std allowlist and flagged string/table/etc. Also silence unused self arg in Queue.__index.

Same changes as PR #23, applied directly to the example server script.

Vendors Rochet2/lualzw 6cbf8ab (release 1.1.0). Default export uses skip = { [0] = true } so wire format matches the former zeros branch. Adds lualzw round-trip tests; documents version in DEPENDENCIES.md.

…les.

Remove unused curmsg (timeout text lives in AIO.lua now), drop unreachable return after error, and use _G.unpack for Lua 5.1 luacheck compatibility.

Luacheck rejects local assert/print/type/select aliases (W122).

Luacheck warns when using length operator on tables with an n field.

Avoid shadowing globals (NewQueue, Smallfolk, lualzw), fix reassembler part counting, and print luacheck output on failure in CI.

Bump AIO_VERSION to 1.76 with CHANGELOG upgrade notes. Add aio_rpc unit tests, CI queue.lua sync check, FUTURE_WORK backlog, and README testing or config docs. Fix unpack in aio_rpc for Lua 5.4 test hosts.

…figs.

…k.on_end.

Load server and client AIO.lua outside WoW to exercise Send, pipeline Init, slash help, and AIO.Handle. Allow table mock players when AIO_TEST_ALLOW_TABLE_PLAYERS is set for the test harness only.

Server integration runs on 5.1-5.4; client integration on 5.1 only. Add CI matrix jobs for 5.2-5.4 server coverage and skip reporting in run.lua.

Keep test-server-lua matrix to run.lua on 5.2-5.4 without duplicate lint steps.

Rochet2 added 30 commits May 31, 2026 07:29

Fix messaging bugs, add tests, CI, and project docs.

92211dc

Correct server cache timing, stored-byte accounting, sethook cleanup, reset persistence, and Windows path basenames; add aio_util helpers, unit tests, Luacheck CI, and SECURITY/DEPENDENCIES docs.

Fix CI: install luacheck via luarocks and use checkout v5.

1cbe73f

Ubuntu Noble has no luacheck apt package; install with luarocks instead. Bump actions/checkout to v5 for Node.js 24 runner support.

Fix CI luacheck: exclude Examples and lint core paths only.

814c592

Example addons use many WoW globals and are not plain Lua; scope luacheck to core modules and tests.

Fix luacheck ignore patterns for AIO.lua warning classes.

b20e3b9

Fix CI luacheck: split strict vs syntax-only checks for AIO.lua.

2a245dc

Lint core modules and tests strictly; run syntax-only checks on the AIO monolith. Pin luarocks to Lua 5.1 and rename a time-diff parameter for parser compatibility.

Normalize line endings to LF and add .gitattributes.

969b7c1

CRLF files caused luacheck trailing-whitespace failures on Linux CI runners.

Fix CI: remove invalid luacheck --no-trailing-space flag.

ebb207c

Fix CI: use gh-actions-lua and scope luacheck to core helpers.

71e6acd

Install Lua 5.1 and luacheck via leafo actions; lint queue/aio_util strictly and syntax-check AIO.lua and tests with lua -p.

Fix CI: use valid leafo/gh-actions-lua tag v9.

71900d6

Fix CI: revert to apt Lua install with scoped luacheck.

31e0d40

Fix CI: use loadfile for Lua 5.1 syntax checks (no -p flag).

7720b9c

Fix CI: use lunarmodules/luacheck action for linting.

23c582c

Fix CI: install luacheck via luarocks with --no-config lint scope.

c2ca3ae

CI: temporarily drop luacheck step to isolate failure.

7fa6f88

Fix CI: install luacheck via luarocks and lint with .luacheckrc.

ba39108

Ubuntu Noble has no luacheck apt package; use luarocks instead. Use project config so scoped lint passes (no-config treated warnings as failures).

Fix CI luacheck: stop per-file globals override in tests.

4e1d1e6

Per-file globals replaced the std allowlist and flagged string/table/etc. Also silence unused self arg in Queue.__index.

Translate KaevStatTest example messages to English.

b065f56

Same changes as PR #23, applied directly to the example server script.

Upgrade vendored lualzw to v1.1.0 with zeros-compatible codec.

5c5d7a6

Vendors Rochet2/lualzw 6cbf8ab (release 1.1.0). Default export uses skip = { [0] = true } so wire format matches the former zeros branch. Adds lualzw round-trip tests; documents version in DEPENDENCIES.md.

Extract messaging into aio_framing, aio_reassembler, and aio_rpc modu…

7071221

…les.

Fix CI: resolve luacheck warnings in aio_rpc.

58d7fef

Remove unused curmsg (timeout text lives in AIO.lua now), drop unreachable return after error, and use _G.unpack for Lua 5.1 luacheck compatibility.

Fix CI: stop shadowing Lua builtins in aio_* modules.

450954b

Luacheck rejects local assert/print/type/select aliases (W122).

Fix CI: avoid # on sparse parts table in reassembler.

ad0fa75

Luacheck warns when using length operator on tables with an n field.

Fix CI luacheck for extracted aio_* modules and tests.

ba8fcbc

Avoid shadowing globals (NewQueue, Smallfolk, lualzw), fix reassembler part counting, and print luacheck output on failure in CI.

Fix CI: restore test globals in tests/*.lua luacheck scope.

54b61d3

Fix CI luacheck: bracket opts keys and sync aio modules.

34acc66

Fix CI: simplify luacheck step (remove broken pipe wrapper).

0812624

CI: list test files explicitly for luacheck.

5f01937

CI: run luacheck via lua5.1 API script on luarocks path.

a8275f2

Fix luacheck warnings in shared modules and restore CLI in CI.

c50c3d4

Release 1.76 notes, RPC tests, and project docs.

7f8703f

Bump AIO_VERSION to 1.76 with CHANGELOG upgrade notes. Add aio_rpc unit tests, CI queue.lua sync check, FUTURE_WORK backlog, and README testing or config docs. Fix unpack in aio_rpc for Lua 5.4 test hosts.

Rochet2 added 30 commits June 1, 2026 04:03

Fix Luacheck W143 in test_aio_core for Lua 5.1 std.

6d890ec

Fix Luacheck W143 in test_aio_rpc for Lua 5.1 std.

c68d08a

CI: Luacheck AIO.lua syntax-only until 5.1 warnings are cleared.

d7dd88f

CI: Luacheck aio_core syntax-only; drop unused second return.

3a2ad25

CI: run luacheck per-file with codes for clearer logs.

c93956d

CI: inline luacheck loop; enforce LF on shell scripts.

8f0d2b6

Fix Luacheck: use _G.unpack only (Lua 5.1); remove invalid ignore 143.

00fd373

Fix unpack for Lua 5.1/5.4; Luacheck ignore 113 not 143.

42a99f1

CI: restore single luacheck invocation; strict aio_core in lint set.

e148747

Fix aio_rpc unpack lint for Lua 5.1 (ignore 113 not 143).

7c4e83a

aio_rpc: use (_G.unpack or table.unpack) at call site for Lua 5.1 lint.

cd03dd5

CI: per-file luacheck with codes to surface failing paths.

9dd46b4

Fix Luacheck W411: rename locals that shadow global unpack.

9d077be

CI: fix luacheck loop (no empty first path from multiline files).

3fd04bb

Fix CI luacheck: bare unpack in aio_rpc; 5.4 test shim; lint test con…

7f42b48

…figs.

CI: split luacheck steps; ignore WoW side modules; rename timeout_hoo…

3532b36

…k.on_end.

CI: bisect luacheck to last known-good file set.

65e49d6

Fix CI: ignore unreachable unpack shim in tests/run.lua on Lua 5.1.

b4b93ae

CI: restore aio_core in luacheck file list.

24f4290

Move Lua 5.4 unpack shim out of run.lua to fix Luacheck on 5.1.

86c6934

Fix Luacheck: ignore constant-if on test_aio_core unpack shim.

75f18f6

CI bisect: skip new tests and WoW luacheck step temporarily.

d846ecf

CI bisect: luacheck only c50c3d4 file set.

342e95e

CI: restore full tests and luacheck; ignore new test files on Lua 5.1.

6bb7590

CI bisect: full tests, c50c3d4 luacheck only.

d0a7c9f

CI: add aio_core to luacheck set.

ce4e7cf

Fix aio_core line length for Luacheck; restore full CI luacheck set.

1c0d03d

Add Eluna/WoW stub harness and AIO.lua integration tests.

f7ef188

Load server and client AIO.lua outside WoW to exercise Send, pipeline Init, slash help, and AIO.Handle. Allow table mock players when AIO_TEST_ALLOW_TABLE_PLAYERS is set for the test harness only.

Gate AIO integration tests by Lua version.

d118daa

Server integration runs on 5.1-5.4; client integration on 5.1 only. Add CI matrix jobs for 5.2-5.4 server coverage and skip reporting in run.lua.

Fix CI: Luacheck and diff on Lua 5.1 job only.

0b2b8d6

Keep test-server-lua matrix to run.lua on 5.2-5.4 without duplicate lint steps.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix messaging bugs, add tests, CI, and project docs#27

Fix messaging bugs, add tests, CI, and project docs#27
Rochet2 wants to merge 65 commits into
masterfrom
aio-improvements

Rochet2 commented May 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Rochet2 commented May 31, 2026

Summary

Test plan

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant