Migrate pkg_resources to importlib#214
Open
robindar wants to merge 1 commit intoRobustBench:masterfrom
Open
Conversation
Use of `pkg_resources.resource_filename` in `loaders.py:20` was deprecated, and has been removed from the standard library in 3.12 (see https://docs.python.org/3/whatsnew/3.12.html). Using the corresponding `importlib` tools fixes it at no cost. It was previously available in `setuptools`, but as of 08 Feb 2026, even setuptools (v82.0.0+) has removed pkg_resources. Either this package must be added to requirements and pinned to v81, or all uses must be migrated to importlib (see https://setuptools.pypa.io/en/stable/history.html#v82-0-0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of
pkg_resources.resource_filenameinloaders.py:20was deprecated, and has been removed from the standard library in 3.12 (see https://docs.python.org/3/whatsnew/3.12.html). Using the correspondingimportlibtools fixes it at no cost.It was previously available in
setuptools, but as of 08 Feb 2026, even setuptools (v82.0.0+) has removed pkg_resources. Either this package must be added to requirements and pinned to v81, or all uses must be migrated to importlib (see https://setuptools.pypa.io/en/stable/history.html#v82-0-0).Other packages also have this issue (see for instance openai/CLIP#528, still open at the time of submitting this pull request).
I have added the test which was in the
__main__block inrobustbench/loaders.pyto its own test filetest/custom_loader_test.pyas I was unsure of how you would want to include these verifications. Let me know if you would like to see it tested differently.