feat: Add delete graph with immediate and period-end cancellation options#111
Merged
feat: Add delete graph with immediate and period-end cancellation options#111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements enhanced delete graph functionality that supports both immediate deletion and period-end cancellation options. This includes a new subscription cancellation API, updated graph client methods, and corresponding model changes to support the two deletion modes.
Key Accomplishments
New Subscription Cancellation API: Added
cancel_repository_subscription.pymodule that handles cancelling repository subscriptions, enabling period-end cancellation flows where a graph's associated subscription can be terminated at the end of the current billing period rather than immediately.Enhanced Delete Graph Operation: Refactored
op_delete_graph.pyto support both immediate deletion and period-end deletion strategies. The operation now accommodates different cancellation semantics depending on the user's intent.Updated Graph Client: Extended
graph_client.pywith new methods and logic to orchestrate the delete graph workflow, integrating the subscription cancellation step when period-end deletion is selected.Updated Data Models: Modified
delete_graph_op.pymodels to include fields and structures necessary to distinguish between immediate and period-end deletion modes.Test Coverage: Added tests in
test_graph_client.pyto validate the new delete graph functionality across both deletion options.Breaking Changes
delete_graph_op.pymay affect serialization/deserialization for consumers relying on the previous schema.Testing Notes
Infrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
chore/update-cancel-repo-submainCo-Authored-By: Claude noreply@anthropic.com