added freezeMiddleware as well as docs for it#72
Open
jakebball wants to merge 5 commits intoRoblox:masterfrom
Open
added freezeMiddleware as well as docs for it#72jakebball wants to merge 5 commits intoRoblox:masterfrom
jakebball wants to merge 5 commits intoRoblox:masterfrom
Conversation
jakebball
changed the title
ZoteTheMighty
suggested changes
Oct 7, 2022
Contributor
ZoteTheMighty
left a comment
ZoteTheMighty
left a comment
There was a problem hiding this comment.
Hi! Could you add a few unit tests to this behavior?
Once you've added some tests, you should be able to accept the CLA and address the CI issues (I believe you'll just need to run StyLua).
|
I need to send |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a freezeMiddleware built in to freeze the reducer state table to enforce immutability rules. Previously impossible per issue here #16 but as mentioned with the addition of table.clone it was trivial to implement.
Very small note:
Added the lua tag to the thunk middleware example on line 271 of of the api reference.