Skip to content

run serialization should not be used if there is no run #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lemire wants to merge 1 commit into from
Closed

run serialization should not be used if there is no run #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions roaringarray.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,17 @@ func (ra *roaringArray) readFrom(stream internal.ByteInput, cookieHeader ...byte
if err != nil {
return stream.GetReadBytes(), fmt.Errorf("malformed bitmap, failed to read is-run bitmap, got: %s", err)
}
isAllZero := true
for i := 0; i < isRunBitmapSize; i++ {
if isRunBitmap[i] != 0 {
isAllZero = false
break
}
}
if isAllZero {
return stream.GetReadBytes(), fmt.Errorf("malformed bitmap, is-run bitmap cannot be all zero")
}

} else if cookie == serialCookieNoRunContainer {
size, err = stream.ReadUInt32()
if err != nil {
Expand Down
Loading