Fix SmartBlock button rendering, vim keybindings, and hotkey overflow#150
Fix SmartBlock button rendering, vim keybindings, and hotkey overflow#150salmonumbrella wants to merge 16 commits intoRoamJS:mainfrom
Conversation
Add occurrence tracking to correctly identify which button was clicked when multiple buttons share the same label. Uses matchAll() to find all button patterns and returns the Nth match based on position. Fixes RoamJS#136
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…w from rebase Rebase silently dropped these changes. Restores: - popoverProps with overflow CSS for hotkey dropdown (RoamJS#147) - Ctrl+n/j/p/k vim-style navigation in SmartBlocks menu (RoamJS#146) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughThis PR introduces SmartBlock button enhancements, clipboard parsing utilities, and expanded keyboard navigation. Key changes include table-context resolution for SmartBlock buttons with multi-occurrence tracking within blocks, new utility functions for parsing hierarchical clipboard text, a MOVEBLOCK command for block relocation, keyboard navigation extensions (Ctrl+N/P and Ctrl+J/K shortcuts), and a dropdown menu height constraint. Documentation is reorganized with a revised README structure, and the migration guide is removed. Package version is bumped to 1.14.0 with comprehensive test coverage for button parsing scenarios. Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi — thank you for putting this together. I appreciate the effort here. We just added a formal contributing guide, so this likely wasn’t visible when you started the PR. Going forward, we’re trying to standardize reviews around it to keep things manageable: https://github.com/RoamJS/contributing/blob/main/contributing.md A couple adjustments are needed before this can move forward:
PRs that touch multiple concerns are significantly harder to review, and I have limited bandwidth right now. Following the guide helps ensure contributions can be reviewed and merged much more quickly. Once this is split up and the Loom is added, I’ll be happy to take a look. |
Summary
j/knavigation,Enterselect) in SmartBlocks menu (feat: add vim-style keyboard navigation to SmartBlocks menu #146)Code Review Remediation
moveBlockAPI availabilitybuttonElementsByBlockUid.clear()on extension unloadTest Plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores