fix(across): fix wrong output token and amount for BRIDGEABLE_TO_ANY …#53
Merged
Conversation
…routes When bridging to a chain where Across performs a swap on the destination (crossSwapType = BRIDGEABLE_TO_ANY), quote.steps.bridge.tokenOut is the intermediate bridge token (e.g. WETH), not the final received token. Previously getQuoteOutputToken always read bridge.tokenOut, causing the 'to' field to display WETH instead of the user-selected token (e.g. POL) and making the output amount look incorrect. Fix: only override the displayed token with bridge.tokenOut for pure bridge routes (BRIDGEABLE_TO_BRIDGE / no crossSwapType). For all other swap types, keep the user-selected toToken so the displayed amount matches the final output reported in quote.expectedOutputAmount.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…routes
When bridging to a chain where Across performs a swap on the destination (crossSwapType = BRIDGEABLE_TO_ANY), quote.steps.bridge.tokenOut is the intermediate bridge token (e.g. WETH), not the final received token.
Previously getQuoteOutputToken always read bridge.tokenOut, causing the 'to' field to display WETH instead of the user-selected token (e.g. POL) and making the output amount look incorrect.
Fix: only override the displayed token with bridge.tokenOut for pure bridge routes (BRIDGEABLE_TO_BRIDGE / no crossSwapType). For all other swap types, keep the user-selected toToken so the displayed amount matches the final output reported in quote.expectedOutputAmount.