Skip to content

Update ECB.php #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webcodes-cz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ECB.php #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/ECB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php

namespace Richardds\ECBAPI;
use Illuminate\Support\Facades\Cache;

/**
* Class ECB
Expand All @@ -14,13 +15,24 @@ class ECB
* @var string
*/
protected const EXCHANGE_REFERENCE_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml';

protected const EXCHANGE_CACHE_HOURS = 1; // may be false to disable caching
//another logic my be required for next day (for example if they publish rates at midnight and you set cache for 3 hours your system may be using till 3am old rates) - thats why Im going to use 1 hour.

/**
* @return Currency[]
* @throws ECBException
*/
public static function getExchangeReferences(): array
{
// Attempt to retrieve the data from cache
$cacheKey = 'exchange_references';
$cachedReferences = Cache::get($cacheKey);

if (self::EXCHANGE_REFERENCE_URL && $cachedReferences !== null) {
return $cachedReferences;
}

// Fetch data from ECB if not in cache
$raw_xml_data = self::fetch(self::EXCHANGE_REFERENCE_URL);

if (($xml = simplexml_load_string($raw_xml_data)) !== false) {
Expand All @@ -42,6 +54,8 @@ public static function getExchangeReferences(): array
$exchange_references[$code] = new Currency($code, $rate);
}

Cache::put($cacheKey, $exchange_references, now()->addHours(self::EXCHANGE_REFERENCE_URL));

return $exchange_references;
}

Expand Down