Using Quotable API to fetch quotes#8
Open
Mudit-Jxin7 wants to merge 2 commits intoRichardJamesWard:masterfrom
Open
Using Quotable API to fetch quotes#8Mudit-Jxin7 wants to merge 2 commits intoRichardJamesWard:masterfrom
Mudit-Jxin7 wants to merge 2 commits intoRichardJamesWard:masterfrom
Conversation
ritish78
reviewed
Jun 19, 2023
ritish78
left a comment
ritish78
left a comment
There was a problem hiding this comment.
An improvement over the current execution but the author has not been active for a while now.
| quote.textContent = data.content; | ||
| cite.textContent = data.author; | ||
| } else { | ||
| quote.textContent = "An error occured"; |
There was a problem hiding this comment.
I think it's better if another element is used to display an error message.
Alert might also do the job. And we leave quote.textContent the same as it was.
devvsakib
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding quotes and their authors, it is preferable to utilize third-party APIs. By leveraging such APIs, the code becomes cleaner and more concise, eliminating the need for manually inputting quotes. I have used one such API to dynamically fetch the quotes and their authors.