Add in a custom sns settings object #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acuthbert
reviewed
Jun 24, 2020
| { | ||
| if (!isset($this->client)) { | ||
| $awsSettings = AwsSettings::singleton(); | ||
| $awsSettings = AwsSnsSettings::singleton(); |
There was a problem hiding this comment.
I think this is currently a breaking change unfortunately. but seems a shame to do a major version bump for such a small change. Can you think of anyway to allow region to be overriden but in a way that if Niacro was updated it would continue to work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.