C make migration#297
Closed
jolavillette wants to merge 8 commits into
Closed
Conversation
… fix C++ bitrot. Plugins not yet supported.
…synchronized dependency paths
G10h4ck
requested changes
May 17, 2026
Contributor
G10h4ck
left a comment
There was a problem hiding this comment.
A big NO from my side, I have saw a few good lines in the PR. But all the rest is messing up all the work I previously made. Basically destroying build time configuration.
| services/p3gxsforums.cc ) | ||
| services/p3gxsforums.cc | ||
| friend_server/fsclient.cc | ||
| friend_server/fsmanager.cc ) |
Contributor
There was a problem hiding this comment.
I am a bit surprised this is appended unconditionally, shouldn't this be included only when friendserver is enabled?
| services/p3statusservice.h | ||
| services/rseventsservice.h ) | ||
| services/rseventsservice.h | ||
| friend_server/fsclient.h |
Contributor
There was a problem hiding this comment.
I am a bit surprised this is appended unconditionally, shouldn't this be included only when friendserver is enabled?
Contributor
Author
|
Closed in favor of a modular cmake implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works together with RetroShare pr/3226
Update: whole project now migrated to CMake
This PR works out of the box on Ubuntu
CMake Build System Migration
This branch introduces a comprehensive migration of the RetroShare build system from QMake to CMake. The goal is to provide a more modern, maintainable, and standard build process for the entire project.
Accomplishments:
Current Status & Caveats: