Fix PublicSuffix validator and UpdateDomainSuffixesCommand#1703
Fix PublicSuffix validator and UpdateDomainSuffixesCommand#1703alganet merged 1 commit intoRespect:3.0from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.0 #1703 +/- ##
============================================
- Coverage 99.47% 99.44% -0.04%
- Complexity 979 1001 +22
============================================
Files 193 193
Lines 2294 2345 +51
============================================
+ Hits 2282 2332 +50
- Misses 12 13 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1c180b0 to
a2bdf8f
Compare
- Parce PSL ICANN section into structured sections (rules, wildcards, exceptions) according to the format. - Updates PublicSuffix semantics for complete application of the rules. - Includes private domain suffixes now. - Refreshes the existing data. - Fixes the update-regionals.yml workflow, set it to run twice a week. References: https://github.com/publicsuffix/list/wiki/Format#format
|
Copilot said it couldn't review, but produced a review nonetheless. I inspected the agent session and fixed the comments it has generated. I'll try requesting the review again. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 299 out of 326 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I am fully aware that this validator got "too big" now, and a separate repository containing the data would be better. However, that is also a tricky move (changing dependencies, making the DataLoader cross vendor or designing a standalone interface for the data). I decided to just deliver it, since the bulk of it is easily removable (data folder) if we want to change course later. |
wildcards, exceptions) according to the format.
the rules.
twice a week.
References: https://github.com/publicsuffix/list/wiki/Format#format