Skip to content

Comments

Fix PublicSuffix validator and UpdateDomainSuffixesCommand#1703

Merged
alganet merged 1 commit intoRespect:3.0from
alganet:regionals
Feb 23, 2026
Merged

Fix PublicSuffix validator and UpdateDomainSuffixesCommand#1703
alganet merged 1 commit intoRespect:3.0from
alganet:regionals

Conversation

@alganet
Copy link
Member

@alganet alganet commented Feb 22, 2026

  • Parce PSL ICANN section into structured sections (rules,
    wildcards, exceptions) according to the format.
  • Updates PublicSuffix semantics for complete application of
    the rules.
  • Includes private domain suffixes now.
  • Refreshes the existing data.
  • Fixes the update-regionals.yml workflow, set it to run
    twice a week.

References: https://github.com/publicsuffix/list/wiki/Format#format

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.44%. Comparing base (e1ff5aa) to head (ee97833).
⚠️ Report is 1 commits behind head on 3.0.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.0    #1703      +/-   ##
============================================
- Coverage     99.47%   99.44%   -0.04%     
- Complexity      979     1001      +22     
============================================
  Files           193      193              
  Lines          2294     2345      +51     
============================================
+ Hits           2282     2332      +50     
- Misses           12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request. There are 300 or more changed files, try reducing the number of files in this pull request and requesting a review from Copilot again.

 - Parce PSL ICANN section into structured sections (rules,
   wildcards, exceptions) according to the format.
 - Updates PublicSuffix semantics for complete application of
   the rules.
 - Includes private domain suffixes now.
 - Refreshes the existing data.
 - Fixes the update-regionals.yml workflow, set it to run
   twice a week.

References: https://github.com/publicsuffix/list/wiki/Format#format
@alganet
Copy link
Member Author

alganet commented Feb 22, 2026

Copilot said it couldn't review, but produced a review nonetheless. I inspected the agent session and fixed the comments it has generated. I'll try requesting the review again.

@alganet alganet requested a review from Copilot February 22, 2026 22:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 299 out of 326 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alganet alganet marked this pull request as ready for review February 22, 2026 22:38
@alganet
Copy link
Member Author

alganet commented Feb 22, 2026

I am fully aware that this validator got "too big" now, and a separate repository containing the data would be better. However, that is also a tricky move (changing dependencies, making the DataLoader cross vendor or designing a standalone interface for the data).

I decided to just deliver it, since the bulk of it is easily removable (data folder) if we want to change course later.

@alganet alganet merged commit 7c8ecfa into Respect:3.0 Feb 23, 2026
7 checks passed
@alganet alganet deleted the regionals branch February 23, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants