refactor(build): remove BepisLoader.runtimeconfig.json overwrites #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assembly dependency resolver refactor (#32) eliminates the need to modify BepisLoader.runtimeconfig.json at build time or runtime.
|
Download the artifacts for this pull request: |
|
u 100% sure that that's correct? I'd like someone on linux to test it. but if we don't need to modify runtimeconfig then it probably means we don't even need to ship it at all, same with deps.json |
Member
Author
|
On linux it would be the same, but no nvm I thought I changed it when I copied over properly but looks like I didn't. my bad it was a fluke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assembly dependency resolver refactor (#32) eliminates the need to modify
BepisLoader.runtimeconfig.jsonat build time or runtime.