RU-T50 Build fix

[ucswift]

Summary by CodeRabbit

• Chores
  • Updated build configuration to improve iOS compatibility for WebRTC functionality.

[coderabbitai]

Warning

Rate limit exceeded

@ucswift has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 11 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 24548ad9-c20d-4349-9d48-7f5074224b34

📥 Commits

Reviewing files that changed from the base of the PR and between 7775a81 and 72ff054.

📒 Files selected for processing (1)

• plugins/withWebRTCFrameworkFix.js

📝 Walkthrough

Walkthrough

This PR adds a new Expo config plugin that automatically patches the iOS Podfile to configure the LiveKit WebRTC framework build settings. The plugin reads the Podfile, inserts a Ruby configuration hook if not already present, and writes the modified Podfile back to disk. The plugin is registered in the Expo configuration.

Changes

WebRTC Framework Fix Plugin

Layer / File(s)	Summary
WebRTC plugin implementation and registration plugins/withWebRTCFrameworkFix.js, app.config.ts	New plugin (withWebRTCFrameworkFix) reads the iOS Podfile, conditionally inserts a build configuration hook after the react_native_post_install() block to set CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = 'YES' for the livekit_react_native_webrtc target, and is registered in the Expo plugins array.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop and skip through Podfiles deep,
Where WebRTC build flags keep,
The framework talking, loud and clear,
No module walls here, my dear! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'RU-T50 Build fix' is vague and does not convey specific information about the changeset beyond a ticket reference, making it unclear what the actual build issue or fix involves.	Replace the title with a more descriptive summary of the specific fix, such as 'Add WebRTC framework configuration plugin for iOS build compatibility' or 'Fix iOS build by adding CLANG compiler flag configuration for WebRTC'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/withWebRTCFrameworkFix.js`:
- Around line 44-56: The loop that searches for the closing ')' of the
react_native_post_install call (using variables depth, insertAfter, anchorIdx,
contents and the for loop) can finish without finding a match and leaves
insertAfter equal to anchorIdx, corrupting the Podfile; after the for loop add
validation: if insertAfter is still anchorIdx (or depth !== 0) then abort the
operation by throwing or returning an error (or logging and returning original
contents) so the hook is not inserted in the wrong place; ensure the check
references insertAfter, anchorIdx and depth and provides a clear error message
indicating an unclosed parenthesis in the react_native_post_install call.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86e1d75b-daad-418b-85cf-3b63073e6b6e

📥 Commits

Reviewing files that changed from the base of the PR and between 6bca369 and 7775a81.

📒 Files selected for processing (2)

• app.config.ts
• plugins/withWebRTCFrameworkFix.js

[ucswift]

Approve

[github-actions]

This PR is approved.