Fix: Pass through version in init=True case#254
Fix: Pass through version in init=True case#254chillenzer wants to merge 1 commit intoResearchObject:masterfrom
version in init=True case#254Conversation
|
Hi @chillenzer, please add a unit test to cover this case |
|
Hi, thanks for the quick response! Sorry, if it's not best quality, just hacked it together in the browser. While looking through the tests, I've only found CLI tests. (Might have overlooked something. If so: Please point me there!) I've added a CLI test and then realized that probably the reason for this not having popped up earlier is that the CLI doesn't support this. So, I've taken the liberty to add a CLI option for this as well. You should feel warmly invited to suggest a better name (naming is hard!) or scold me for this frivolous act. I've explicitly not chosen |
|
Yes, I should've definitely not just hacked it in the browser. I'll do it properly next week. |
5ff8262 to
4c8bb49
Compare
|
Sorry for the delay. @simleo should work now. |
Thanks for this great project! I've just started using it and it works quite well!
However, this tiny oversight had me scratching my head for quite a while: In
init=Truemode, theversionparameter ofROCrate.__init__is not passed through to__init_from_tree.