Fix GC corruption via two upstream PRs. #272
Merged
+100
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We store the previous scope in the eh_state and thus hide it from GC. This means we need to manually preserve that scope across the `try ... catch`, instead fo the new scope that we switch to. --------- Co-authored-by: Nathan Daly <nathan.daly@relational.ai> Co-authored-by: Keno Fischer <keno@juliacomputing.com>
Since this task's stack or scope field could have been modified after it was marked by an incremental collection (and not just for copy stacks), move the barrier back unconditionally here. --------- Co-authored-by: Valentin Churavy <v.churavy@gmail.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
kpamnany
force-pushed
the
nhd-gc-crash-2
branch
from
e60fb61 to
d9ba0a0
Compare
kpamnany
approved these changes
Jan 16, 2026
kpamnany
pushed a commit
that referenced
this pull request
Jan 16, 2026
* Preserve the scope across the exception handler (JuliaLang#60647) We store the previous scope in the eh_state and thus hide it from GC. This means we need to manually preserve that scope across the `try ... catch`, instead fo the new scope that we switch to. --------- Co-authored-by: Nathan Daly <nathan.daly@relational.ai> Co-authored-by: Keno Fischer <keno@juliacomputing.com> * add wb_back on all task switch paths (JuliaLang#60617) Since this task's stack or scope field could have been modified after it was marked by an incremental collection (and not just for copy stacks), move the barrier back unconditionally here. --------- Co-authored-by: Valentin Churavy <v.churavy@gmail.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> --------- Co-authored-by: Valentin Churavy <v.churavy@gmail.com> Co-authored-by: Keno Fischer <keno@juliacomputing.com> Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
kpamnany
pushed a commit
that referenced
this pull request
Jan 16, 2026
* Preserve the scope across the exception handler (JuliaLang#60647) We store the previous scope in the eh_state and thus hide it from GC. This means we need to manually preserve that scope across the `try ... catch`, instead fo the new scope that we switch to. --------- Co-authored-by: Nathan Daly <nathan.daly@relational.ai> Co-authored-by: Keno Fischer <keno@juliacomputing.com> * add wb_back on all task switch paths (JuliaLang#60617) Since this task's stack or scope field could have been modified after it was marked by an incremental collection (and not just for copy stacks), move the barrier back unconditionally here. --------- Co-authored-by: Valentin Churavy <v.churavy@gmail.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com> --------- Co-authored-by: Valentin Churavy <v.churavy@gmail.com> Co-authored-by: Keno Fischer <keno@juliacomputing.com> Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Backport JuliaLang#60647 and JuliaLang#60617 to RAI v1.12.
Fixes JuliaLang#59483.
Replaces #271.
Checklist
Requirements for merging:
port-to-*labels that don't apply.