Use generic mapSolution + SipserReduceToSAT3 instead of reverseMappedSolution#89
Open
wrigjl wants to merge 1 commit into
Open
Conversation
…Solution
In requestSolvedInstanceTemporarySat3CliqueSolver, switch the
"map the clique back to a 3SAT assignment" call from the
per-reduction SAT3 controller endpoint
`SipserReduceToCliqueStandard/reverseMappedSolution` to the generic
`ProblemProvider/mapSolution` route, dispatched via the inverse
reduction class `SipserReduceToSAT3`. Body shape changes from the
three-field `{problemFrom, problemTo, problemFromSolution}` envelope
to a plain instance string, matching how every other call site uses
the generic mapSolution route.
This removes the last caller of `reverseMappedSolution`, clearing the
way for ReduxISU/Redux#214 to delete the endpoint and method in the
Redux C# repo.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
requestSolvedInstanceTemporarySat3CliqueSolver(components/redux/index.js), switch the "map the clique back to a 3SAT assignment" call from the per-reduction SAT3 controller endpointSipserReduceToCliqueStandard/reverseMappedSolutionto the genericProblemProvider/mapSolutionroute, dispatched via the inverse reduction classSipserReduceToSAT3. Body shape changes from the three-field {problemFrom, problemTo, problemFromSolution} envelope to a plain instance string, matching how every other call site in this file uses the generic mapSolution route.This is the GUI half of the cleanup tracked by ReduxISU/Redux#214. It removes the only remaining caller of reverseMappedSolution, after which the Redux C# repo can delete the endpoint, its controller route, and the orphaned reverseMapSolutions method on
SipserReduceToCliqueStandard. The Redux C# side will need both PRs in flight before either is reviewed safely: this PR alone leaves reverseMappedSolution unused but still defined; the C# deletion PR alone would break this GUI call site if merged first. Suggested order: merge this PR, then the C# deletion PR.The new call requires
SipserReduceToSAT3to exist in the running Redux C# backend, which it does on the clique-to-sat3 branch (ReduxISU/Redux#213).