Fix stale XML param tags in SAT3_Controller.cs (CS1572/CS1573)#227
Open
wrigjl wants to merge 1 commit into
Open
Fix stale XML param tags in SAT3_Controller.cs (CS1572/CS1573)#227wrigjl wants to merge 1 commit into
wrigjl wants to merge 1 commit into
Conversation
mapSolution and reverseMappedSolution endpoints take a single MapSolution parameter, but doc comments still referenced the old three-param signature (problemFrom, problemTo, problemFromSolution/problemToSolution). Fixes 17 CS1572/CS1573 build warnings across four controllers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wrigjl
force-pushed
the
fix/sat3-controller-param-docs
branch
from
07b35d0 to
d9f371c
Compare
wrigjl
added
the
low-risk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapSolutionandreverseMappedSolutionendpoints in four controllers (SipserReduceToCliqueStandard,KarpIntProgStandard,GareyJohnson, andKarpReduceGRAPHCOLORING) take a singleMapSolutionparameter, but their XML doc comments still referenced the old three-parameter signature (problemFrom,problemTo,problemFromSolution/problemToSolution).<param>tags on each affected method with a single correct<param name="mapSolution">tag.