Skip to content

MOD-14661 Disable SVS bounds checking #924

Merged
meiravgri merged 1 commit intomainfrom
meiravg_disable_bounds_check_svs
Mar 30, 2026
Merged

MOD-14661 Disable SVS bounds checking #924
meiravgri merged 1 commit intomainfrom
meiravg_disable_bounds_check_svs

Conversation

@meiravgri
Copy link
Copy Markdown
Collaborator

@meiravgri meiravgri commented Mar 30, 2026

Disable SVS bounds checking (SVS_EXPERIMENTAL_CHECK_BOUNDS=OFF) when building deps/ScalableVectorSearch from source (non-SVS_SHARED_LIB path).

This addresses a race condition where indexLabelCount() is called concurrently with background indexing in tiered SVS, triggering an exception from SVS's translation table bounds check. Disabling the bounds check avoids the crash until the SVS submodule is bumped to a version that includes the upstream fix (intel/ScalableVectorSearch#301).

Which issues this PR fixes

  1. MOD-14661 - Bump deps/svs version and compile with SVS_EXPERIMENTAL_CHECK_BOUNDS=OFF
  2. Related to MOD-14618 - Race condition in tiered SVS: indexLabelCount() called without locks causes crash

Main objects this PR modified

  1. cmake/svs.cmake - Added set(SVS_EXPERIMENTAL_CHECK_BOUNDS OFF CACHE BOOL "..." FORCE) before add_subdirectory for the in-tree SVS build

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Medium Risk
Build-time change that alters SVS runtime validation behavior and could mask out-of-bounds bugs when using the in-tree SVS build. Scope is limited to the non-SVS_SHARED_LIB path in cmake/svs.cmake.

Overview
Disables SVS bounds checks in the vendored build. When SVS_SHARED_LIB is off (building deps/ScalableVectorSearch from source), the CMake now forces SVS_EXPERIMENTAL_CHECK_BOUNDS=OFF via cache before add_subdirectory, changing SVS compilation defaults for that dependency.

Written by Cursor Bugbot for commit 1057155. This will update automatically on new commits. Configure here.

@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Mar 30, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (42fdc90) to head (1057155).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         129      129           
  Lines        7574     7574           
=======================================
  Hits         7346     7346           
  Misses        228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri changed the title disable bounds check in svs MOD-14661 Disable SVS bounds checking Mar 30, 2026
@meiravgri meiravgri requested a review from alonre24 March 30, 2026 12:32
@meiravgri meiravgri enabled auto-merge March 30, 2026 12:33
@meiravgri meiravgri added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit f177c40 Mar 30, 2026
17 checks passed
@meiravgri meiravgri deleted the meiravg_disable_bounds_check_svs branch March 30, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants